Skip to content

Simplify binding structure#546

Merged
edeutsch merged 2 commits into2.0from
simplify-bindings
Feb 19, 2026
Merged

Simplify binding structure#546
edeutsch merged 2 commits into2.0from
simplify-bindings

Conversation

@tokebe
Copy link

@tokebe tokebe commented Feb 12, 2026

This simplification changes bindings so they all change from looking like this:

...
"<node/edge/path>_bindings": {
          "key1": [
            {
              "id": "<CURIE/EdgeID/AuxGraphID>"
            }
          ],
          "key2": [
            {
              "id": "<CURIE/EdgeID/AuxGraphID>"
            }
          ]
        },
...

to this:

...
"<node/edge/path>_bindings": {
          "key1": {
            "ids": ["<CURIE/EdgeID/AuxGraphID>"]
          }
          "key2": {
            "ids": ["<CURIE/EdgeID/AuxGraphID>"]
          }
        },
...

The reasoning for keeping the binding objects, rather than making it a simple id: array, is to leave room for possible future changes to set_interpretation response formatting. A likely-enough future change would be to use unified binding objects so attributes can be attached that reference the set of nodes/aggregation of edges (instead of the current format of using reasoner-constructed Nodes and Edges with support graphs). This format allows for that possibility, as well as testing prior to future TRAPI changes because the binding objects allow for arbitrary additional properties.

@edeutsch edeutsch requested a review from colleenXu February 19, 2026 20:42
@tokebe
Copy link
Author

tokebe commented Feb 19, 2026

Addresses #505, #515, #517

@edeutsch edeutsch merged commit 4081b08 into 2.0 Feb 19, 2026
2 checks passed
@colleenXu
Copy link
Contributor

colleenXu commented Feb 19, 2026

Documenting origin:

We already knew we wanted to flatten the bindings (see linked issues in previous comment).

Then when thinking over set_interpretation/MCQ, Willow and I discussed ways that node/edge bindings could be simplified yet also have space to include set/enrichment info. (slides proposal, caveat in internal Slack)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments